Skip to content

Lazy load avatar images #32051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2024
Merged

Lazy load avatar images #32051

merged 3 commits into from
Sep 17, 2024

Conversation

@hiifong
Copy link
Member

@hiifong hiifong commented Sep 16, 2024

Before:

before.mp4

After:

after.mp4

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 16, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 16, 2024
@yp05327 yp05327 changed the title set avatar image to lazy loading Lazy load avatar images Sep 17, 2024
@yp05327 yp05327 added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. performance/speed performance issues with slow downs labels Sep 17, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) September 17, 2024 18:03
@techknowlogick techknowlogick merged commit f38e101 into go-gitea:main Sep 17, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Sep 17, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 17, 2024
@hiifong @GiteaBot
Lazy load avatar images (go-gitea#32051)
359565f
@GiteaBot GiteaBot mentioned this pull request Sep 17, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 17, 2024
@hiifong hiifong deleted the lazy branch September 18, 2024 01:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 18, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5a0b68b 
* giteaofficial/main:
  Add missing comment reply handling (go-gitea#32050)
  Fix CI (go-gitea#32062)
  Lazy load avatar images (go-gitea#32051)
  Included tag search capabilities (go-gitea#32045)
  Do not escape relative path in RPM primary index (go-gitea#32038)
  feat(go-gitea#31666): Set the columns height to hug all its contents (go-gitea#31726)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Use a common message template instead of a special one (go-gitea#31878)
  Check if the `due_date` is nil when editing issues (go-gitea#32035)
lunny pushed a commit that referenced this pull request Sep 18, 2024
@GiteaBot @hiifong
Lazy load avatar images (#32051) (#32063)
2831ae3 
Backport #32051 by @hiifong

Before:

https://github.com/user-attachments/assets/7b1681ba-4781-432a-ae20-c07e94c1dbb6

After:

https://github.com/user-attachments/assets/5154e160-e22c-460e-b0d9-28768486c178

Co-authored-by: hiifong <[email protected]>
@yp05327 yp05327 modified the milestones: 1.24.0, 1.23.0 Sep 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code performance/speed performance issues with slow downs

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hiifong @lunny @delvh @techknowlogick @yp05327 @GiteaBot